btlqql opened a new pull request, #2518:
URL: https://github.com/apache/rocketmq-dashboard/pull/2518

   ## What is the purpose of the change
   
   Usernames may be up to 128 characters, but the `queried_by` columns of 
`rmq_instance_message` and `rmq_instance_trace` were `VARCHAR(64)`. When a user 
with a 65-128 character name ran a message or trace query, the history insert 
failed and `MessageService` swallowed the exception - the business query 
succeeded while the history row was silently lost.
   
   ## Brief changelog
   
   - widened `queried_by` to `VARCHAR(128)` in both query-history tables
   - appended idempotent `ALTER TABLE ... MODIFY` upgrades so pre-existing 
databases pick up the wider columns when the DDL is re-applied (fresh databases 
already get them from the CREATE statements)
   - added an integration test that records a message query and a trace query 
under a 128-character username and asserts both rows come back from the history 
listings with the full, untruncated owner
   
   ## How was this patch verified
   
   - server: `QueryHistoryServiceIntegrationTest` green; the same test fails 
when the columns are reverted to `VARCHAR(64)`, proving it catches the original 
bug; full `mvn test` green apart from the 7 pre-existing environment failures 
in the CLI agent tests (missing `sh` binary on a Windows machine, identical on 
the clean base)
   
   Fixes #2491
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to