RockteMQ-AI commented on PR #378: URL: https://github.com/apache/rocketmq-dashboard/pull/378#issuecomment-5383921616
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** In `AclInfo.copyFrom()` (src/main/java/org/apache/rocketmq/dashboard/model/AclInfo.java, lines 196-197), the method calls `new ArrayList<>(entry.getActions())` and `new ArrayList<>(entry.getSourceIps())` without null checks. When an ACL entry has `null` actions or sourceIps (which is valid in the upstream `org.apache.rocketmq.remoting.protocol.body.AclInfo`), `new ArrayList<>(null)` throws a `NullPointerException`, causing the entire `listAcls` API call to fail. **Impact:** The ACL listing feature in the dashboard becomes unusable when any ACL entry has null actions or sourceIps fields. **Severity:** medium **Suggested Fix:** Add null checks before wrapping in ArrayList: ```java copiedEntry.setActions(entry.getActions() != null ? new ArrayList<>(entry.getActions()) : new ArrayList<>()); copiedEntry.setSourceIps(entry.getSourceIps() != null ? new ArrayList<>(entry.getSourceIps()) : new ArrayList<>()); ``` --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
