RockteMQ-AI commented on issue #10956: URL: https://github.com/apache/rocketmq/issues/10956#issuecomment-5394905914
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** Controller module (remoting server, auth pipeline) **Compatibility:** Non-breaking when authentication is disabled by default; new auth pipeline only activates when `AuthConfig` is enabled. Well-structured report. The Controller remoting server indeed lacks the authentication/authorization request pipeline that exists for Broker and Proxy. The proposed fix aligns with the existing auth architecture. Key considerations: - Ensure signed inner-client requests from Brokers to Controller continue working without user-facing credentials. - The `CLEAN_BROKER_DATA` and broker ID allocation request codes are high-impact — auth coverage here is important for cluster integrity. - Regression tests should cover both standalone and embedded Controller startup paths. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
