RockteMQ-AI commented on issue #1338: URL: https://github.com/apache/rocketmq-clients/issues/1338#issuecomment-5394956737
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** Java client metrics pipeline **Compatibility:** Non-breaking — opt-in via system property, no API changes. Well-designed proposal following Kafka JmxReporter pattern. The approach of reusing existing client metrics and exposing them through MBeans (without adding Prometheus dependencies or network ports) is clean and production-friendly. Key considerations: - MBean lifecycle must be tightly coupled with client lifecycle (register on start, unregister on shutdown). - The JVM system property approach for enabling is appropriate for opt-in behavior. - Consider documenting the MBean names and attribute descriptions for Prometheus JMX Exporter configuration. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
