btlqql opened a new pull request, #2572:
URL: https://github.com/apache/rocketmq-dashboard/pull/2572

   ## What is the purpose of the change
   
   ``updateTopic`` only wrote the remark when ``StringUtils.hasText()`` passed, 
so submitting a blank value behaved exactly like not submitting one and the 
stored remark could never be removed.
   
   ## Brief changelog
   
   - treat a null remark as "not submitted" (keep the stored value) and a 
submitted blank/whitespace remark as "clear" (store null), trimming the value 
in between
   - echo the persisted remark back on the response so the returned VO reflects 
the stored state instead of the raw request value
   
   ## How was this patch verified
   
   - ``RocketMQAdminClientImplTest`` 37/37 green, including two new cases: 
blank submission clears the stored remark, omitted remark keeps it
   - ``TopicControllerTest`` 14/14 and ``MetadataServiceTest`` 21/21 green on 
JDK 21
   
   Fixes #2497
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to