RockteMQ-AI commented on code in PR #2574:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2574#discussion_r3852572820
##########
web/src/pages/instance/consumer.tsx:
##########
@@ -97,13 +97,20 @@ import {
type ResourceImportRow,
} from '../../utils/resourceCsvImport';
import { buildCsv, downloadCsv, type CsvColumn } from '../../utils/download';
+import { formatLag, isLagAvailable, lagSortValue } from
'../../utils/consumerLag';
import { tableScrollX } from '../../utils/table';
const { Text } = Typography;
/* ─── Helpers ─── */
+const UNKNOWN_LAG_COLOR = '#8c8c8c';
+const UNAVAILABLE_LAG_LABEL = '不可用';
Review Comment:
**[Warning]** `UNAVAILABLE_LAG_LABEL` is hardcoded as Chinese-only text.
This PR already adds the translation key `groupMgmt.lagUnavailable` in
`translations.ts`, and `GroupManagement.tsx` correctly uses
`t('groupMgmt.lagUnavailable')`. For consistency, this component should also
use the translation key instead of a hardcoded string, so the English locale
renders "Unavailable" rather than Chinese text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
