ai-yang commented on PR #10938: URL: https://github.com/apache/rocketmq/pull/10938#issuecomment-5441504735
Update after refreshing this PR against the latest `develop`: - rebased onto `e348efa66b08eb645ee123706ea6492fa9a3ad35` (RocketMQ 5.5.1); - squashed the implementation and follow-up test change into one signed-off commit (`2c793417c`); - reran the complete `common` test suite: 245/245 passed; - reran `ReceiptHandleGroupTest`, which was the only failing test in the previous Ubuntu CI job: 7/7 passed; - `git diff --check` passed. The previous `ReceiptHandleGroupTest` failure is not reproducible on the refreshed head and is outside this PR's changed files. The force-push has retriggered the full CI matrix. @RongtongJin, since you have recent context in `MessageDecoder`, could you please take a human review when available, particularly for wire compatibility and the shared sizing/writing helpers? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
