ai-yang commented on PR #10937: URL: https://github.com/apache/rocketmq/pull/10937#issuecomment-5441507222
Update after refreshing this PR against the latest `develop`: - rebased onto `e348efa66b08eb645ee123706ea6492fa9a3ad35` (RocketMQ 5.5.1); - extended the lifecycle regression to call `start()` twice and `shutdown()` twice on the same producer, verifying that the shared accumulator is acquired and released exactly once; - `ProduceAccumulatorTest` and `DefaultMQProducerTest`: 46/46 passed; - Checkstyle, SpotBugs, and `git diff --check` passed in the affected reactor build. The force-push has retriggered the full CI matrix and should also exercise the previously partial `DefaultMQProducer.start()` branch in patch coverage. @guyinyou, since you have context in `ProduceAccumulator`, could you please take a human review when available, especially around the reference-counted lifecycle and repeated start/shutdown behavior? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
