wang-jiahua commented on code in PR #10971:
URL: https://github.com/apache/rocketmq/pull/10971#discussion_r3877216972
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java:
##########
@@ -128,15 +128,15 @@ public PullResult processPullResult(final MessageQueue
mq, final PullResult pull
this.executeHook(filterMessageContext);
}
+ String minOffset = Long.toString(pullResult.getMinOffset());
+ String maxOffset = Long.toString(pullResult.getMaxOffset());
for (MessageExt msg : msgListFilterAgain) {
Review Comment:
Good catch — moved the two stringifications together with the loop inside an
`if (!msgListFilterAgain.isEmpty())` guard, so fully-filtered batches allocate
nothing (commit 634e146).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
