ai-yang commented on PR #10986: URL: https://github.com/apache/rocketmq/pull/10986#issuecomment-5463237778
CI triage update: - The Bazel job executed 573 tests; 572 passed and the sole failure was `//test:.../OffsetResetIT`. - This PR only changes `PopReviveService` and `PopReviveServiceTest`; the affected test class passes 13/13, and the Maven, coverage, license, CodeQL, Windows, and macOS jobs all passed. - I found no direct overlap between `OffsetResetIT` and this focused exceptional POP-revive read path, so I am rerunning the failed Bazel job before making any code change. @lizhimins @xdkxlk, could you please take a human review when convenient? The main review point is whether converting an exceptional business-message read to the existing `rePutCK` path correctly preserves POP at-least-once retry semantics without broadening exception handling around `reviveRetry`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
