ai-yang commented on PR #10701: URL: https://github.com/apache/rocketmq/pull/10701#issuecomment-5463252649
Refreshed this PR onto the current `develop` (`e348efa66`) and force-pushed one signed-off commit (`03695c870`). I also added an inline explanation for the per-key `synchronized(map)` block: it orders the in-memory update, whole-map snapshot, and WAL write so an older snapshot cannot overwrite newer offsets. - `ConsumerOffsetManagerTest` + `RocksDBConsumerOffsetManagerTest`: 21/21 passed; - all 10 modules in the targeted `broker -am` reactor succeeded; - Checkstyle and SpotBugs reported no findings; - `git diff --check` passed. The production change is +37/-20 lines; +261/-6 lines are deterministic concurrency/persistence tests. Full CI has been retriggered. @RongtongJin @lizhimins, could you please take a human review when convenient, especially of same-key WAL ordering and the classic/RocksDB v1 initialization paths? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
