RockteMQ-AI commented on code in PR #2822:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2822#discussion_r3888278988
##########
web/src/services/aclService.ts:
##########
@@ -96,6 +96,9 @@ export async function pageAclUsers(params: {
pageSize: number;
}): Promise<AclUserPage> {
if (isMockMode()) {
+ if (params.page < 1 || params.pageSize < 1 || params.pageSize > 100) {
Review Comment:
**[Warning]** The combined error message works with the current
substring-based tests, but it would be clearer to throw separate errors for
each validation failure. This gives callers precise feedback about which
parameter is invalid. Not blocking - the current behavior is functionally
correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
