RockteMQ-AI commented on code in PR #463:
URL: https://github.com/apache/rocketmq-connect/pull/463#discussion_r3890868360


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/utils/ConnectUtil.java:
##########
@@ -111,21 +109,49 @@ public static AllocateConnAndTaskStrategy 
initAllocateConnAndTaskStrategy(Worker
         }
     }
 
-    public static DefaultMQProducer initDefaultMQProducer(WorkerConfig 
connectConfig) {
+    public static DefaultMQProducer initDefaultMQProducer(WorkerConfig 
connectConfig, ConnectKeyValue keyValue) {

Review Comment:
   **[Info]** The overloaded `initDefaultMQProducer(WorkerConfig)` method now 
delegates to the new method with `null` keyValue. This is a clean 
backward-compatible approach. Consider adding a brief Javadoc comment to 
explain the `USE_NAMESRV_OF_CONNECTOR` flag behavior for future maintainers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to