tju-yxq commented on PR #2697: URL: https://github.com/apache/rocketmq-dashboard/pull/2697#issuecomment-5476889058
Review follow-up for commit `bfcb7a90`: - Replaced the reflection-only `@Transactional` metadata test with a Spring/H2 behavioral test. The new test invokes the proxied `NativeAlertEvaluationService`, forces alert persistence to fail after state persistence, verifies the probe write is rolled back, then runs a successful evaluation and verifies the next transaction commits. - Kept the existing continuation and `Error` propagation unit coverage. - Added a short comment to `aggregate()` explaining that the snapshot-window read runs inside the evaluation's independent transaction. - The processor already logs evaluation failures at `WARN`; no `ERROR` logging is used for expected transient failures. Verification: - `mvn -q '-Dtest=NativeAlertProcessorTest,NativeAlertEvaluationTransactionTest' test` passed (15 tests total). - Checkstyle passed with 0 violations. - `git diff --check` passed. The branch remains based on the current `rocketmq-studio` head. GitHub Actions may still report the repository-level startup failure already documented on this PR; that is separate from the local behavioral test result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
