The GitHub Actions job "License checker" on 
rocketmq.git/fix/networkutil-and-indexservice-guards has failed.
Run started by GitHub user btlqql (triggered by btlqql).

Head commit for run:
582609610b2f6cbbd1b5747323a9a89cf4f4370c / btlqql <[email protected]>
fix: guard NPE in NetworkUtil and concurrent read in IndexService

- NetworkUtil.socketAddress2String: InetSocketAddress.getAddress() returns
  null when the hostname is unresolved, so getAddress().getHostAddress()
  threw NPE; fall back to getHostString() when the address is null
- NetworkUtil.string2SocketAddress: an address without ':' made
  lastIndexOf return -1 and substring(0, -1) threw
  StringIndexOutOfBoundsException; throw a clear IllegalArgumentException
- IndexService.getTotalSize: indexFileList is a plain ArrayList guarded by
  readWriteLock everywhere else, but getTotalSize read it without the lock,
  so a concurrent destroy()/deleteExpiredFile() could clear it between the
  isEmpty() check and get(0), causing IndexOutOfBoundsException; acquire the
  read lock

Compiled and verified on the build server (mvn -pl broker -am compile).

Report URL: https://github.com/apache/rocketmq/actions/runs/30703591883

With regards,
GitHub Actions via GitBox

Reply via email to