RockteMQ-AI commented on code in PR #2863:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2863#discussion_r3897741852
##########
server/src/main/java/org/apache/rocketmq/studio/settings/SettingsService.java:
##########
@@ -147,6 +147,28 @@ public synchronized void
saveGeneralSettings(GeneralSettingsVO settings) {
if (!StringUtils.hasText(settings.getAwsRegion())) {
settings.setAwsRegion(currentSettings.getAwsRegion());
}
+ // The settings blob has two partial writers: the general-settings
save does not
+ // manage the LLM tuning values, and the LLM-config save does not
manage the
+ // notification fields. An absent (null) value therefore inherits
the stored one,
+ // while an explicit empty string still clears a text field.
Review Comment:
Good documentation of the two-writer invariant. One consideration: if more
fields are added later, the null-check boilerplate will grow linearly. A small
helper method could keep this maintainable. Not blocking — just a thought for
future iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
