RockteMQ-AI commented on issue #2912:
URL:
https://github.com/apache/rocketmq-dashboard/issues/2912#issuecomment-5498248451
**Issue Evaluation**
Category: `bug` | Status: **Needs Info**
The issue claims `SystemGroupFilter` "matches any group that starts with
`CID_` or contains `_MONITOR`", but the actual implementation in
`SystemGroupFilter.isSystem()` uses specific prefix matching:
```java
return group.startsWith("CID_RMQ_SYS_")
|| group.startsWith("CID_ONSAPI_")
|| group.startsWith("CID_SYS_")
|| group.startsWith("CID_HOUSEKEEPING")
|| group.startsWith("rmq_sys_")
|| group.startsWith("%RETRY%")
|| group.startsWith("%DLQ%")
|| group.startsWith("TOOLS_CONSUMER")
|| group.startsWith("FILTERSRV_CONSUMER")
|| group.startsWith("SELF_TEST_");
```
The filter does **not** match all `CID_` prefixed groups — only specific
system prefixes (`CID_RMQ_SYS_`, `CID_ONSAPI_`, `CID_SYS_`,
`CID_HOUSEKEEPING`). There is also no `_MONITOR` pattern in the current
implementation.
Could you clarify:
1. Which version/branch exhibits the broader matching behavior you describe?
2. Are you reporting a regression from an older implementation, or proposing
a change to the current filter?
The current implementation appears to correctly distinguish system groups
from legitimate application groups that happen to use `CID_` prefixes.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
