yyqdbngt opened a new pull request, #2934: URL: https://github.com/apache/rocketmq-dashboard/pull/2934
## Summary - `GrafanaDashboardList` and `AlertRuleAssetList` now keep only real strings when building tag/severity filter options, searching rows, and rendering tag cells - Adds a regression test per component: a list entry with a non-string tag/severity value (e.g. `42`/`null` from a malformed wire payload) no longer crashes the list ## Why Both components flatten `tags`/`severities` from the API and immediately call string methods on the values: `localeCompare` in the options sort and `toUpperCase()` in the tag cell. A single non-string entry (a number or `null` in the wire payload) threw a `TypeError` during render, crashing the whole list view. The search filters had the same exposure via `value.toLowerCase()`. ## Testing - `./node_modules/.bin/vitest run src/components/__tests__/GrafanaDashboardList.test.tsx src/components/__tests__/AlertRuleAssetList.test.tsx` → 18 passed (2 new; verified both fail with the pre-fix components) - `./node_modules/.bin/tsc --noEmit` → clean - `./node_modules/.bin/eslint` on the 4 changed files → 0 errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
