yyqdbngt opened a new pull request, #2941:
URL: https://github.com/apache/rocketmq-dashboard/pull/2941

   ## Summary
   - guard `QueryHistoryService.purgeExpiredQueries` against a 
`DateTimeException` when the configured retention pushes the cutoff outside the 
`LocalDateTime` date range
   - add a regression test that an out-of-range retention skips the purge 
instead of throwing
   
   ## Why
   `LocalDateTime.now(clock).minusDays(retentionDays)` ran outside any 
try/catch, so a misconfigured `studio.query-history.retention-days` (e.g. 
several hundred million days) would throw a `DateTimeException` on every 
schedule tick and silently kill both the message and trace history purges, 
leaving stale rows forever. The purge now logs a warning and skips the tick, 
keeping the failure visible without breaking the schedule.
   
   ## Testing
   - `cd server && mvn -q -Dtest=QueryHistoryServiceTest test` — all tests 
pass, including the new `skipsPurgeWhenRetentionExceedsTheDateRange`
   - `cd server && mvn -q -Dtest=QueryHistoryControllerTest test` — all tests 
pass (regression for the history endpoints)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to