RockteMQ-AI commented on issue #2951: URL: https://github.com/apache/rocketmq-dashboard/issues/2951#issuecomment-5502855577
**Issue Evaluation** Category: `bug` | Status: **Needs Info** I reviewed the alert metric validation code on the `pr-2533-review` branch. In `AlertRuleEvaluator.evaluate()`, the rule metric is trimmed before comparing with the sample's `metricKey()`, but the sample metric key itself is not normalized. This asymmetry could allow whitespace-padded metric keys to bypass matching. However, to confirm the full impact, I need clarification: - [ ] Which code path introduces the whitespace into metric keys? (metric collection, rule creation API, or database storage?) - [ ] Is the `metric_key VARCHAR(128)` column in `rmq_metric_snapshot` expected to store pre-trimmed values, or should trimming happen at the evaluation layer? - [ ] Are there specific reproduction steps or a failing test case? Once confirmed, the fix would involve normalizing metric keys at the ingestion boundary and ensuring consistent comparison in the evaluator. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
