lizhimins commented on PR #2642: URL: https://github.com/apache/rocketmq-dashboard/pull/2642#issuecomment-5509005668
Thanks for this work! Since this PR was opened, the mainline has merged #2807, which rewrites `CollectorScheduler.collect()` with a whole-pass timeout budget — this branch now conflicts with it. Could you rebase onto the latest `rocketmq-studio` and reconcile the two designs? Your lease heartbeat/renewal and #2807's pass budget are complementary (the pass budget prevents one round from running forever; your heartbeat prevents long rounds from losing the lease), so the rebased version should keep both: whole-pass deadline plus periodic `renew()` during collection. Once rebased we'll take another look. Note the branch may also need to absorb #2957 (sliding-window collection) which landed later and touches the same scheduler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
