RockteMQ-AI commented on issue #10998: URL: https://github.com/apache/rocketmq/issues/10998#issuecomment-5509980208
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** In `MessageStoreDispatcherImpl.doScheduleDispatch` (`tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreDispatcherImpl.java`, lines 260-266), the batch-building loop checks `bufferSize >= groupCommitSize` **before** appending the current message. When the very first message's `cqUnit.getSize()` is already >= `groupCommitSize`, the loop breaks immediately, leaving both `appendingBufferList` and `dispatchRequestList` empty. **Impact:** - `commitAsync` (guarded by `if (!dispatchRequestList.isEmpty())` at lines 303-311) is never called - The tiered ConsumeQueue offset does not advance (line 296 sets `endOffset == currentOffset`) - The method returns `false` (line 336), causing the scheduler to retry the same offset indefinitely - All subsequent messages for this topic are blocked from archiving to tiered storage **Severity:** High — a single oversized message (still within the 4MB max limit) can permanently stall tiered storage dispatch for the entire topic. **Suggested Fix:** The size check should allow at least one message to be appended per batch, even if it exceeds `groupCommitSize`. For example, change the condition to `if (bufferSize >= groupCommitSize && !appendingBufferList.isEmpty())` so the first oversized message is still included. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation, `/revise` to request a different approach, or `/reject` to decline. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
