RockteMQ-AI commented on issue #958: URL: https://github.com/apache/rocketmq-dashboard/issues/958#issuecomment-5530745707
**Issue Evaluation** Category: `bug` | Status: **Evaluated - Code Not in Main Branch** The reported issue describes a valid serialization bug where `@JsonProperty(access = WRITE_ONLY)` causes the API key to be omitted from both REST responses AND database persistence. However, the referenced code (`GeneralSettingsVO`, `MybatisPlusSettingsRepository`) does not exist in the current `master` branch (last commit: 770822bb, 2026-07-22). **Analysis:** - The Jackson serialization conflict between API redaction and persistence is a real and common pitfall - The described behavior (key works in-memory but lost after restart) is consistent with the root cause - The acceptance criteria correctly separate the two concerns (API response vs persistence) **Recommendation:** This issue references code from the MySQL-backed settings repository work (related to #813 and #863). The fix should use a separate DTO or `@JsonView` for persistence vs API serialization. **Next Steps:** - Link this issue to the PR that introduces `MybatisPlusSettingsRepository` - Verify the bug against that codebase - Apply fix using separate serialization contexts before merging --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
