unbridled-41 commented on issue #3103: URL: https://github.com/apache/rocketmq-dashboard/issues/3103#issuecomment-5543281478
Submitted a fix as draft PR #3151. The fix gives every registry row an instance identity: the probed NameServer endpoint is matched against the configured Apache instance endpoints (comma/semicolon/space separated lists are tokenized), and the row's actions require a unique owner. - Broker config preview/update, Broker config diff, and NameServer config diff now target the row's owning instance instead of the route instance. - When zero or multiple instances own the endpoint, the action fails closed with an explicit error message instead of sending the request to a guessed instance. - The config modal freezes its target when opened, so a later route change cannot retarget the write. Scope notes versus the acceptance criteria in this issue: stale-response discard within one modal generation is handled separately in #3154 (the Broker config diff had no request generation guard at all, so a closed dialog could self-reopen and a slower response could overwrite a newer request), and unmappable rows are rejected at click time with an explicit error rather than disabled per-row — the fail-closed property is identical, with more actionable feedback. Happy to switch to per-row disabling if preferred. Regression tests cover the cross-instance routing case (route=instance-a, row owned by instance-b), the missing-mapping case, and the ambiguous shared-endpoint case; all three fail against the previous behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
