tju-yxq opened a new pull request, #3160: URL: https://github.com/apache/rocketmq-dashboard/pull/3160
## What is the purpose of the change The Consumer Group page's Push/Pop selector previously filtered only the rows already loaded for the current page. The backend paged endpoint had no subscription-mode parameter, so the page total still described the unfiltered inventory and later pages could be unreachable for the selected mode. ## What changed - add an optional `subscriptionMode` request parameter to `/api/groups/page` - pass the normalized mode through `MetadataService`, `InstanceProvider`, `ApacheInstanceProvider`, and `MetadataProvider` - filter Apache-backed groups in the database query using `message_model`, preserving correct totals and ordering - retain compatible default methods for providers without native mode filtering - send the selected mode from the Consumer Group page and stop filtering the current page client-side - update controller/service/provider/API/page tests ## Verification - backend focused tests: `ConsumerGroupControllerTest,RocketMQMetadataProviderTest,MetadataServiceTest,ApacheInstanceProviderTest,InstanceProviderTest` passed - frontend focused tests: `ConsumerPage.test.tsx`, `consumerGroups.test.ts`, `consumerService.test.ts` passed (49 tests) - Checkstyle: 0 violations - frontend lint: 0 errors (existing warnings only) - frontend build: passed - full server suite: 2,003 tests, 0 failures, 0 errors - production/config diff: 43 additions and 28 deletions across backend and frontend (41 production additions); this is the natural fix size, not padded with unrelated changes Closes #3150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
