unbridled-41 commented on PR #3154:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3154#issuecomment-5543783663
## Verification evidence (supplementary)
**Why CI is red on this PR:** repo-wide pre-existing CI breakage — every
`ci.yml` run has failed at startup (`startup_failure`, zero jobs executed)
since 2026-08-28, including upstream's own pushes to `rocketmq-studio` and all
contributor PRs ("This run likely failed because of a workflow file issue";
last `ci.yml` change was PR #2621, 2026-08-27). This branch does not modify
`ci.yml` (diff vs `origin/rocketmq-studio` is empty). CI-equivalent
verification was run locally:
**Regression tests (red → green)**
- Red, before the fix: `npx vitest run
src/pages/cluster/__tests__/ClusterPage.test.tsx -t 'Broker config diff'`
- `does not reopen a closed Broker config diff when its request finishes`
→ failed (× 1399ms): after clicking 关闭, resolving the pending
`getBrokerConfigDiff` re-opened the dialog, so
`expect(dialog).toHaveClass('ant-zoom-leave')` failed.
- `keeps the requested broker config diff when a slower response finishes
last` → failed (× 6646ms): the slower first response overwrote the modal, so
the title switched to the stale cluster (`ns-stale`) and the drift banner (`检测到
Broker 配置不一致`) replaced the requested cluster's no-drift result.
- Green, after the fix: full file run → 24/24 pass (both new tests plus the
22 pre-existing ones, including the NameServer twin regression test).
**Module / related suites**
- `npx tsc -p tsconfig.app.json --noEmit` → clean; `eslint` on both changed
files → clean.
**Full suite and build (CI frontend equivalents)**
- Full `npx vitest run --testTimeout=60000 --hookTimeout=60000` on this
branch → 924 tests (922 baseline + 2 new), 1 failed / 923 passed. The single
failure is `ConsumerPage.test.tsx > shows group health diagnostics from
subscriptions, progress and clients` — a file this PR does not touch. The full
suite is load-flaky in this sandbox (repeated pristine runs produce different
failure sets: 9/4 files, 15/7, then 3; all near the configured 20s
`testTimeout`), and this exact test passes in isolation both on pristine (53/53
across ConsumerPage/AclPage/NotificationDeliveriesPage) and on a sibling branch
(ConsumerPage 50/50). No deterministic failure exists on this branch.
- `npm run build` (CI frontend-build equivalent) → succeeds.
No new commits were added for this; the code and tests were already complete
— this comment documents the verification the broken CI could not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
