unbridled-41 commented on PR #3156:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3156#issuecomment-5543785810
## Verification evidence (supplementary)
**Why CI is red on this PR:** repo-wide pre-existing CI breakage — every
`ci.yml` run has failed at startup (`startup_failure`, zero jobs executed)
since 2026-08-28, including upstream's own pushes to `rocketmq-studio` and all
contributor PRs ("This run likely failed because of a workflow file issue";
last `ci.yml` change was PR #2621, 2026-08-27). This branch does not modify
`ci.yml` (diff vs `origin/rocketmq-studio` is empty). CI-equivalent
verification was run locally:
**Regression test (red → green)**
- Red, before the fix: `npx vitest run
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx -t 'empty trace
query'` → `keeps the trace tab responsive when an empty trace query supersedes
an in-flight load` failed with `TestingLibraryElementError: Unable to find an
element with the text: 请输入 Message ID` — exactly the defect: the stuck
`traceLoading` spinner takes render precedence, so the validation error set by
the empty-input branch was never rendered.
- Green, after the fix: same command passes; the test asserts the error is
visible, the spinner is gone, and the late in-flight trace response does not
resurrect the spinner.
**Module / related suites**
- `npx vitest run
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx
src/pages/instance/__tests__/MessagePage.test.tsx` → 28/28 pass.
- `npx tsc -p tsconfig.app.json --noEmit` → clean; `eslint` on both changed
files → clean.
**Full suite and build (CI frontend equivalents)**
- Full `npx vitest run --testTimeout=60000 --hookTimeout=60000` on this
branch → 923 tests (922 baseline + 1 new), 1 failed / 922 passed. The single
failure is `ConsumerPage.test.tsx > shows group health diagnostics from
subscriptions, progress and clients` — a file this PR does not touch. The full
suite is load-flaky in this sandbox (repeated pristine runs produce different
failure sets: 9/4 files, 15/7, then 3; all near the configured 20s
`testTimeout`), and this exact test passes in isolation both on pristine (53/53
across ConsumerPage/AclPage/NotificationDeliveriesPage) and on a sibling branch
(ConsumerPage 50/50). No deterministic failure exists on this branch.
- `npm run build` (CI frontend-build equivalent) → succeeds.
No new commits were added for this; the code and tests were already complete
— this comment documents the verification the broken CI could not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
