yyqdbngt opened a new pull request, #3246:
URL: https://github.com/apache/rocketmq-dashboard/pull/3246

   ## Summary
   
   Adds `ConsumerConnectionsTest`, a first unit test for the package-private 
mapping from a broker/proxy `ConsumerConnection` payload to the online 
`ConsumerInstanceVO` view shared by the group listing and group detail.
   
   Coverage:
   - a `null` connection and a connection without a connection set both map to 
an empty instance list;
   - every connection in the set is mapped to an instance carrying its 
`clientId` and `clientAddr` (asserted in any order, since the payload holds a 
`HashSet`).
   
   ## Why
   
   The mapping is the single source of truth for online consumer instances in 
the group pages; it had no direct test.
   
   ## Testing
   
   `mvn -B test -Dtest=ConsumerConnectionsTest` — 2/2 pass; checkstyle 
(validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to