unbridled-41 commented on PR #11044:
URL: https://github.com/apache/rocketmq/pull/11044#issuecomment-5551619926
Evidence chain (audit 2026-09-05):
**Before the fix** — ff8f6f74c; the queued channel-destroy unregister was
executed through the exact public path the service thread uses
(`unRegisterBroker(Set<UnRegisterBrokerRequestHeader>)`), after
register(channel1) → register(channel2) with the same address:
```
java.lang.AssertionError: fresh registration must survive the stale destroy
request
at ...ScratchPreFixCheckTest.preFix_staleDestroyWipesFreshRegistration
```
(harness was a scratch test not included in the commit; the committed
regression tests exercise the same semantics deterministically via the post-fix
package-private seam)
**After the fix** — branch tip 6a2e768c7, re-measured 2026-09-05:
```
mvn -pl namesrv test -Dtest=RouteInfoManagerNewTest
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0
mvn -pl namesrv test
-Dtest=RouteInfoManagerTest,RouteInfoManagerBrokerRegisterTest,RouteInfoManagerStaticRegisterTest
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
```
Three new tests pin the semantics: stale channel-destroy is skipped;
same-channel destroy still removes; explicitly initiated unregister (null
expected channel) stays unconditional.
**Baseline noise note**: running `RouteInfoManagerNewTest` on the unfixed
baseline already logs 29 occurrences of "unregisterBroker Exception" / "Handle
unregister broker request failed" (teardown/async noise measured via a stashed
baseline run); the fixed run logs fewer of them with 0 test failures — the log
noise is pre-existing, not introduced here.
**CI**: 9/10 checks pass. The single windows-latest failure
(`ConsumerOrderInfoManagerLockFreeNotifyTest` awaitility 6s timeout, broker
module) is unrelated to this namesrv-only change — see the earlier comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
