yyqdbngt opened a new pull request, #3319:
URL: https://github.com/apache/rocketmq-dashboard/pull/3319

   ## Summary
   
   Extends the existing `NativeAlertMetricCatalogServiceTest` (2 to 6 tests) to 
pin down metric catalog resolution and validation.
   
   Added cases:
   - `list` rejects blank instance ids (400) and unknown instances (404);
   - a Tencent instance resolves the cloud metric sets for both business and 
cluster domains (previously only Aliyun was covered);
   - an instance without a vendor falls back to the Apache metric sets;
   - `validate` accepts supported native metrics and tolerates null rules.
   
   ## Why
   
   The catalog declares which native metrics alert rules may use per provider; 
instance/vendor resolution branches had no coverage beyond Aliyun/Apache happy 
paths.
   
   ## Testing
   
   `mvn -B test -Dtest=NativeAlertMetricCatalogServiceTest` — 6/6 pass; 
checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to