unbridled-41 commented on PR #3349:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3349#issuecomment-5552136613
### Verification evidence
- **Red first:** with the fix stashed, `AliyunConvertersTest` failed with
the actual output:
```
toSubscriptionEntryShouldDeriveFilterModeFromTheExpressionType — expected:
"SQL" but was: null
toSubscriptionEntryShouldKeepTagFilterMode — expected: "TAG" but was: null
```
(3 run / 2 failed.)
- **Module tests after the fix:** `mvn -B -ntp test
-Dtest='AliyunConvertersTest,AliyunInstanceProviderTest'` →
AliyunConvertersTest 3/3 passing; AliyunInstanceProviderTest keeps only its
pre-existing pristine-baseline failure (`getGroupProgressShouldMapLagRowsTest`,
unrelated to subscriptions).
- **Full suite:** `mvn -B -ntp test` on this branch → 2037 tests (pristine
baseline 2035 + 2 new); the only 3 failures (`AuthCorsIntegrationTest` ×2,
`AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest`) are verbatim
the pristine-baseline failures. Zero new failures.
- **CI:** upstream workflows for `rocketmq-studio` PR branches are in
`startup_failure` (workflow never starts; same for all recent PRs including
other contributors'). Nothing from this branch reaches CI execution.
- **Scoring:** PRIORITY 72 (impact 28 + scope 10 + reproducibility 20 +
maintenance value 14), FIX_CONFIDENCE 92.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
