unbridled-41 commented on PR #3342:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3342#issuecomment-5552136341
### Verification evidence
- **Red first:** with the fix stashed, `MybatisPlusAclRepositoryTest` failed
with the actual output:
```
MybatisPlusAclRepositoryTest.replaceUserShouldExplicitlyClearClusterBindingsWhenListIsEmpty:234
Wanted but not invoked: userMapper.update(isNull(), <Capturing argument:
UpdateWrapper>);
userMapper.updateById(RmqAclUser(id=1, username=svc-a, ..., clusters=null,
...))
```
(22 run / 2 failed — both new clear-cases;
`replaceRuleShouldExplicitlyClearActionsWhenListIsEmpty` failed the same way.)
- **Module tests after the fix:** `mvn -B -ntp test
-Dtest='MybatisPlusAclRepositoryTest,AclServiceTest,AclControllerTest'` →
22/22, 64/64, 27/27 passing.
- **Full suite:** `mvn -B -ntp test` on this branch → 2038 tests (pristine
baseline 2035 + 3 new). Failures: `AuthCorsIntegrationTest` ×2 and
`AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest` — verbatim
the recorded pristine-baseline failures — plus one load-flaky
`OpenAiCompatibleLlmGatewayTest.successfulAndFailedStreamsEmitOneTerminalSequence`
("AI chat capacity is temporarily exhausted"), which passes 9/9 in isolation
and shares no code with this change. Zero new deterministic failures.
- **CI:** the repository's workflows for PR branches to `rocketmq-studio`
have been reporting `startup_failure` (workflow never starts) for all recent
PRs including other contributors'; see e.g. #3300/#3301 runs. Nothing from this
branch reaches CI execution.
- **Scoring:** PRIORITY 84 (impact 34 + scope 14 + reproducibility 20 +
maintenance value 16), FIX_CONFIDENCE 85.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
