yyqdbngt opened a new pull request, #3356:
URL: https://github.com/apache/rocketmq-dashboard/pull/3356

   ## Summary
   
   Extends the existing `ApacheRocketMqBusinessMetricsCollectorTest` (5 to 7 
tests) to pin down the Apache business collector contract.
   
   Added cases:
   - `supports` accepts Apache and vendor-less instances with a name, and 
rejects cloud vendors, unnamed instances, and null;
   - `metricKeys` exposes the four business metrics (`consumer.lag.total`, 
`consumer.lag.max_queue`, `consumer.delay.seconds`, `topic.backlog.total`).
   
   ## Why
   
   The collector feeds native Apache business alerting; the vendor/name gate 
and the metric-key contract were not covered before.
   
   ## Testing
   
   `mvn -B test -Dtest=ApacheRocketMqBusinessMetricsCollectorTest` — 7/7 pass; 
checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to