RockteMQ-AI commented on issue #3357: URL: https://github.com/apache/rocketmq-dashboard/issues/3357#issuecomment-5552338794
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** `MybatisPlusAclRepository.replaceUser` (line 128) and `replaceRule` (line 80) use MyBatis-Plus `updateById`, which by default uses the `NOT_NULL` field strategy — null entity fields are excluded from the generated UPDATE SQL. When a user clears cluster bindings (`clusters → null`) or rule actions (`actions → null`), the corresponding columns are silently omitted from the update. **Impact:** Users believe they have cleared bindings/actions, but the old values persist in the database. The change appears to succeed (HTTP 200) but is not durable. **Severity:** high (silent data inconsistency in security-sensitive ACL configuration) **Verification:** Code at `MybatisPlusAclRepository.java:135` confirms `userMapper.updateById(entity)` with null cluster/action fields. The `toUserEntity` mapper sets clusters to null, but `updateById` skips null columns. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
