Copilot commented on code in PR #3398:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3398#discussion_r3940984698
##########
server/src/main/java/org/apache/rocketmq/studio/ops/audit/MybatisPlusAuditRepository.java:
##########
@@ -97,9 +98,10 @@ public AuditFilterOptionsVO findFilterOptions() {
private AuditFilterOptionsVO loadFilterOptions() {
List<Map<String, Object>> values = auditMapper.selectMaps(
new QueryWrapper<RmqOperationAudit>()
- .select("operation", "resource_type", "cluster_id",
"result")
- .groupBy("operation", "resource_type", "cluster_id",
"result"));
+ .select("operation", "resource_type", "cluster_id",
"result", "operator")
+ .groupBy("operation", "resource_type", "cluster_id",
"result", "operator"));
Review Comment:
`loadFilterOptions()` now groups by five columns
(`operation/resource_type/cluster_id/result/operator`). This can significantly
increase the number of grouped rows versus the previous 4-column grouping,
especially if `operator` has high cardinality, and the query is re-run every
30s due to the short cache TTL. Consider fetching operators with a separate
distinct/group-by query (or a distinct select) to avoid the combinatorial
explosion while keeping the existing facet query unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
