unbridled-41 commented on PR #3346:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3346#issuecomment-5552136461
### Verification evidence
- **Red first:** with the fix stashed, `RocketMQMetadataProviderTest`
produced the production-shaped errors:
```
getTopicRoutesShouldReturnEmptyListWhenTopicHasNoBrokerRoute →
BusinessException
Failed to get routes for topic TopicA: CODE: 17 DESC: Not found topic
route info in name server for topic: TopicA
getTopicConsumersShouldReturnEmptyPageWhenTopicHasNoBrokerRoute →
BusinessException
Failed to get consumers for topic TopicA: CODE: 17 DESC: Not found
topic route info in name server for topic: TopicA
```
(37 run / 2 errors.)
- **Module tests after the fix:** `mvn -B -ntp test
-Dtest='RocketMQMetadataProviderTest,MetadataServiceTest,TopicControllerTest'`
→ 37/37, 36/36, 16/16 passing. The pre-existing
`getTopicRoutesSurfacesAdminFailure` / `getTopicConsumersSurfacesAdminFailure`
tests (IllegalStateException → 502) still pass, confirming real admin failures
keep surfacing as errors per the #1163 concern.
- **Full suite:** `mvn -B -ntp test` on this branch → 2037 tests (pristine
baseline 2035 + 2 new); the only 3 failures (`AuthCorsIntegrationTest` ×2,
`AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest`) are verbatim
the pristine-baseline failures. Zero new failures.
- **CI:** upstream workflows for `rocketmq-studio` PR branches are in
`startup_failure` (workflow never starts; same for all recent PRs including
other contributors'). Nothing from this branch reaches CI execution.
- **Scoring:** PRIORITY 76 (impact 30 + scope 12 + reproducibility 20 +
maintenance value 14), FIX_CONFIDENCE 90.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
