tju-yxq opened a new pull request, #3710:
URL: https://github.com/apache/rocketmq-dashboard/pull/3710

   ## What changed
   
   The System Alerts header said how many alerts were unacknowledged, but that 
value was computed from only the rows loaded on the current page. The page also 
supports level, domain, instance, transition, label, time-range, and 
suppression filters, so the displayed count did not describe the filtered 
result set.
   
   This change makes the header count result-set wide:
   
   - add a `GET /api/system-alerts/summary` endpoint;
   - return total and unacknowledged counts in one aggregation query;
   - apply the same filters as the paged alert feed;
   - keep the existing validation for inverted time ranges and incomplete label 
filters;
   - add a typed frontend API and service wrapper;
   - load the summary with the alert page and use its unacknowledged value in 
the header;
   - keep a page-local fallback only if the summary request fails.
   
   Closes #3557
   
   ## Validation
   
   - `mvn -q 
'-Dtest=AlertServiceTest,SystemAlertControllerTest,MybatisPlusAlertRepositoryTest'
 test` — 107 tests passed
   - `mvn -q checkstyle:check` — passed
   - `npm test -- SystemAlertsPage.test.tsx --run` — 15 tests passed
   - `npm run lint -- --quiet` — 0 errors; 10 existing warnings remain 
elsewhere in the tree
   - `npm run build` — passed
   - `git diff --check` — passed
   
   The GitHub Actions status is not being described as green here; the checks 
above are local validation on this branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to