RockteMQ-AI commented on code in PR #3770:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3770#discussion_r3941991210
##########
server/src/main/java/org/apache/rocketmq/studio/ops/alert/NotificationOutboxService.java:
##########
@@ -222,6 +226,32 @@ public PageResult<NotificationDeliveryPageVO>
listDeliveries(String channel, Str
(long) (safePage - 1) * safePageSize), total, safePage,
safePageSize);
}
+ public String exportDeliveries(String channel, String status, String
instanceId) {
+ String normalizedChannel = normalizeFilter(channel);
+ String normalizedStatus = normalizeStatus(status);
+ String normalizedInstanceId = normalizeTrim(instanceId);
Review Comment:
**[Info]** `MAX_EXPORT_DELIVERIES = 10_000` is a reasonable cap. Consider
adding a comment explaining the rationale (e.g. "Excel row limit compatibility"
or "memory safety bound") so future maintainers understand why this specific
number was chosen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
