yyqdbngt opened a new pull request, #3774: URL: https://github.com/apache/rocketmq-dashboard/pull/3774
### Motivation The existing `AlertNotificationSuppressionServiceTest` locks in the correlation window, resolved-incident and pagination behaviour, but the early-exit guards and the final `max` selection among several in-scope incidents are untested. ### Changes - `ignoresNonBusinessDomainEventsWithoutQueryingRepository`: cluster-domain events short-circuit with an empty result and no repository interaction. - `ignoresBusinessEventsWithoutTimestampWithoutQueryingRepository`: business events without a `time` never issue the correlation query. - `picksTheMostRecentFiringAcrossMatchingIncidents`: when several cluster incidents match the scope, the newest firing alert is returned as the suppressing cause. ### Verification ``` mvn -B test -Dtest=AlertNotificationSuppressionServiceTest [INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
