yyqdbngt opened a new pull request, #3772: URL: https://github.com/apache/rocketmq-dashboard/pull/3772
### Motivation The existing `AlertRuleSemanticFingerprintTest` proves presentation-insensitivity, scope/window sensitivity and ratio-threshold normalisation, but several normalisation branches of the fingerprint remain untested. ### Changes - `domainDefaultsToBusinessAndBlankInstanceMatchesNull`: a null domain is folded to `BUSINESS` and a blank instance id is folded to null, keeping the fingerprint stable. - `blankAggregationFallsBackToLastWhileExplicitValueChangesFingerprint`: whitespace-only `aggregation` behaves like the `LAST` default while an explicit `AVG` changes the identity. - `percentageUnitStaysRawForNonRatioMetrics`: for metrics outside the ratio set the `%` unit does not rescale the threshold, so 85 with `%` matches raw 85 and differs from 0.85. - `negativeWindowAndConsecutiveSamplesAreClamped`: negative `windowSeconds`/`consecutiveSamples` clamp to their safe floors (0/1) and keep the identity of the clamped rule. ### Verification ``` mvn -B test -Dtest=AlertRuleSemanticFingerprintTest [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
