yyqdbngt opened a new pull request, #3832:
URL: https://github.com/apache/rocketmq-dashboard/pull/3832

   ### Motivation
   
   The existing `NativeAlertMetricCatalogServiceTest` covers provider-filtered 
catalogs and metric normalisation, but the list guards (blank/unknown instance) 
and the validate short-circuit for non-native metrics were untested.
   
   ### Changes
   
   - `listShouldRejectBlankInstanceId`: a null or whitespace-only instance id 
raises 400 `instanceId is required`.
   - `listShouldRejectUnknownInstance`: an unknown instance identifier raises 
404 `Instance not found`.
   - `validateShouldSkipRepositoryForNonNativeMetrics`: custom (non-native) 
metric names are trimmed and returned without any repository lookup.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=NativeAlertMetricCatalogServiceTest
   [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to