yyqdbngt opened a new pull request, #3845: URL: https://github.com/apache/rocketmq-dashboard/pull/3845
### Motivation The existing `ApacheRocketMqProxyMetricsCollectorTest` covers healthy probes, malformed addresses and discovery failure. The per-proxy probe failure, proxy-less clusters and null proxy rows were untested. ### Changes - `probeFailureMarksTheProxyUnavailable`: a probe exception degrades that proxy to unavailable while keeping its address label and cluster id. - `clustersWithoutProxyListsAreSkipped`: clusters with a null proxy list contribute nothing while sibling clusters with proxies are still probed. - `nullProxyRowsYieldUnavailableWithUnknownLabel`: a null proxy entry degrades to unavailable under the `unknown` address label with the cluster name as the cluster id. ### Verification ``` mvn -B test -Dtest=ApacheRocketMqProxyMetricsCollectorTest [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
