unbridled-41 commented on PR #4002:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4002#issuecomment-5560942495
## Verification evidence
**CI**: upstream `apache/rocketmq-dashboard` CI cannot run in this
environment. Head commit `cd33f79d257bea997e0d51e8f42e1cd6acc6251c`:
`commits/{sha}/check-runs` → `total_count: 0`, `commits/{sha}/status` → 0
statuses; the single workflow run recorded for this head SHA ("CI",
pull_request) ended `startup_failure` (workflow never started). Recent
`rocketmq-studio` base-branch runs show the same `startup_failure`, i.e.
pre-existing and unrelated to this change.
**Red light (before the fix)** — `mvn -B -ntp test
-Dtest='RocketMQClientProviderTest'`:
```
RocketMQClientProviderTest.consumerScanTreatsOfflineGroupsAsEmptyInsteadOf502:515
» Business Failed to query consumer connections from all groups
RocketMQClientProviderTest.producerQueryWithExplicitOfflineGroupReturnsEmptyInsteadOf502:548
» Business Failed to query producer connections: Not found the producer
group connection
Tests run: 27, Failures: 0, Errors: 2
```
(The third new test,
`consumerScanReturnsOfflineGroupResultsWhenAnotherGroupFails`, passes before
and after — it locks in that an offline group does not poison a mixed scan.)
**Green light / module tests (after the fix)**: `Tests run: 27, Failures: 0,
Errors: 0` (24 pre-existing + 3 new; the pre-existing
`consumerScanFailsWhenEveryGroupConnectionQueryFails` still asserts genuine
failures → 502).
**Full suite + baseline**: `mvn -B -ntp test` → `Tests run: 2038, Failures:
3`. The 3 failures are the pristine-baseline set
(AuthCorsIntegrationTest.shouldRejectNonAdminMutationBeforeControllerExecution,
AuthCorsIntegrationTest.shouldStillRejectAnonymousProtectedRequests,
AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest — identical
messages to the recorded pristine baseline of 2035 tests / same 3 failures).
Zero new failures; 2035 baseline + 3 new tests = 2038.
**Build**: compile clean; the full-suite `BUILD FAILURE` is solely the
pre-existing baseline test failures listed above; `mvn -B -ntp clean package`
compilation is covered by the suite run and the backend-build job's compile
step (no compilation warnings introduced).
**Diff self-check**: 2 files, +66/−3 — `RocketMQClientProvider.java`
(+26/−3: per-group offline classification + `isGroupConnectionAbsent` helper)
and `RocketMQClientProviderTest.java` (+43: 3 regression tests). No unrelated
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
