Palaiologos1453 opened a new pull request, #11060:
URL: https://github.com/apache/rocketmq/pull/11060

   ### Which Issue(s) This PR Fixes
   
   - Fixes #11059
   
   ### Brief Description
   
   `GET_LITE_CLIENT_INFO` validates the requested parent topic and group 
binding, but retrieves a subscription by client ID without checking its group 
or topic. A request for group A can therefore return group B's client details 
labeled as group A.
   
   Compare the existing subscription's group and parent topic with the request 
before returning any client details. Mismatches return `INVALID_PARAMETER` 
without a response body or the actual subscription metadata in the error 
message. Matching empty subscriptions and absent subscriptions retain their 
existing results.
   
   ### How Did You Test This Change?
   
   With Amazon Corretto 8u482 and Maven 3.9.11:
   
   ```sh
   mvn -B -pl broker -am 
-Dtest=LiteManagerProcessorTest,LiteSubscriptionRegistryImplTest 
-DfailIfNoTests=false test
   ```
   
   - 55 tests passed with no failures, errors, or skips. Checkstyle and 
SpotBugs passed.
   - The ownership regression fails on the unmodified processor: `expected:<29> 
but was:<0>` (`INVALID_PARAMETER` versus `SUCCESS`).
   - Coverage includes group-only, topic-only, and combined mismatches, each 
with empty and nonempty subscription sets. Rejected requests do not read client 
last-access time.
   - Matching empty, matching nonempty, and absent subscriptions are covered. 
The existing success fixture now supplies the ownership fields that the 
registry sets in production.
   - `git diff --check` passed. No live-cluster or ACL behavior was tested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to