lizhimins commented on issue #4020: URL: https://github.com/apache/rocketmq-dashboard/issues/4020#issuecomment-5581038811
Closing this issue. Two PRs attempted the coverage it asks for, and neither could be merged. - #4021 (btlqql) - withdrawn unmerged by its own author on 2026-09-07. - #4067 (Yanghanrui666) - closed today as a verbatim duplicate of #4021: same target test file, same added lines byte for byte, and it claimed `Closes #4020` despite this issue having been filed by a different contributor. The reason we are closing the issue rather than asking for a third attempt is that the coverage requested here would not add value: The blank and undefined paths of `normalizeAuditCode`, `formatAuditCode` and `parseAuditDetail` are pure presentation functions whose empty-value behaviour is already pinned by existing cases in `web/src/pages/ops/__tests__/auditPresentation.test.ts`. The submitted test added no defect and no increment - it re-asserted an already-fixed output. To be clear about scope: this is a judgement about these six specific assertions, not a stance against frontend tests. Substantive frontend tests are merged here regularly. The actual testing gap in this repository is a different one, and it is still open and unclaimed: the `Frontend Build (Node 20)` job in `.github/workflows/ci.yml` runs `npm ci` followed by `npm run build` and never runs `vitest`, so none of the roughly 936 existing frontend tests gate anything. Two of them are already flaky (`AlertsPage > disables other alert rule mutations while a bulk action is running` and `TopicPage > keeps the selected instance when rebuilding...`), and `ci.yml` itself currently fails at startup so no checks are reported on any PR at all. A PR that stabilises those two and wires `npm run test` into the frontend job would do more for this codebase than any of the six test files requested by this batch of issues. If you believe a specific assertion here does have value, please open a new issue that names the uncovered branch with observable behaviour and shows that the test fails when the guarded code is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
