unbridled-41 commented on PR #4189: URL: https://github.com/apache/rocketmq-dashboard/pull/4189#issuecomment-5596766014
## Verification evidence - **CI**: head SHA `298736606a4725ba33bc7270b6bf53264fcc527a` has exactly one workflow run — `CI (pull_request)`, conclusion `startup_failure`, 0 check-runs (upstream workflow fails before launching jobs; all `rocketmq-studio` branches show the same). Suites were therefore run locally. - **Red-light actual output** (before the fix, same test, `rocketmq-studio` @ 0a596661): ``` × reuses the selected range when the instance prop changes 724ms Expected: start 1799978400, step '2m' (6h window) Received: start 179996400, step '30s' (1h default, the reload after instance-1 → instance-2) ``` - **Module tests**: `npx vitest run src/components/__tests__/MetricsExplorer.test.tsx` → 21/21 passed after the fix. Determinism check: 4 consecutive full-file runs + 1 `--sequence.shuffle` run, all 21/21 (an earlier draft of this test asserted `toHaveBeenLastCalledWith` immediately after rerender without first waiting for the third call, which made it racy; the committed test waits for `toHaveBeenCalledTimes(3)` first — that racy draft was discarded, never committed). - **Full suite + baseline**: `npx vitest run` → 945 tests, 944 passed, 1 failed (`ConsumerPage > shows group health diagnostics from subscriptions, progress and clients`, untouched file). Isolated run of that file/test with this change applied: passed (load flakiness; the recurring flaky file in this sandbox across previous rounds). - **Build**: `npx tsc --noEmit` clean; `npx eslint` on both changed files 0 errors/0 warnings; `npm run build` succeeded (9.08s). - **Diff self-check** (`git show --numstat 29873660`): `web/src/components/MetricsExplorer.tsx` +12/−1, `web/src/components/__tests__/MetricsExplorer.test.tsx` +28/−0; total 2 files, +40/−1. No unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
