lizhimins commented on PR #4137: URL: https://github.com/apache/rocketmq-dashboard/pull/4137#issuecomment-5602088715
Closed as folded into #4115, merged into `rocketmq-studio` as 206314b9. Your change shipped as-is: `AliyunConverters.toTopicVO` now sets `TopicPerm.RW` and both cloud `toTopicType` implementations fall back to `TopicType.NORMAL` instead of returning null for a blank or unrecognised type. The Aliyun perm gap was the more serious half — ListTopics returns no permission field and nothing downstream filled it in, so every Aliyun topic had a null perm and `TopicListToolHandler.safeProjection` threw on its first `requiredEnumName` call. Worth recording that you scoped this correctly: you changed `type` and `perm` but left `messageCount`, `tps` and `consumerGroupCount` alone, which no provider populates either. Defaulting those too would have masked genuinely absent data rather than fixing a broken invariant, so the restraint was the right call. Nothing further needed from you — thank you for the fix. For context on why these were grouped: the AI resource tool chain had four independent defects (argument-slot routing, output-schema nullability, cloud topic type/perm, cloud consumer-group subscription mode) and merging any single one of them would not have made `rmq.topic.list` or `rmq.group.list` usable, so they were integrated as one change on the target PR's branch, each kept as its own commit with you as the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
