89799969 opened a new pull request, #4204: URL: https://github.com/apache/rocketmq-dashboard/pull/4204
## Summary - make system-alert event acknowledgement and active-state acknowledgement share one transaction - roll both database writes back when updating the matching FIRING state fails - preserve the existing stale-occurrence behavior where the state repository returns `false` - add an H2-backed regression test for rollback and successful retry ## Problem `AlertService#acknowledgeAlert` first marks `rmq_system_alert` as acknowledged and then updates the matching `rmq_alert_state`. Without a transaction, an exception from the second write leaves the event acknowledged while the active state is still FIRING, so reminder evaluation can continue for an incident the UI shows as acknowledged. Fixes #4203 ## Verification - `mvn -B -Dmaven.repo.local=D:\projects\oss-contributions\m2-rocketmq -Dtest=AlertAcknowledgementTransactionTest,AlertServiceTest test` - 77 tests passed, 0 failures, 0 errors - Checkstyle: 0 violations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
