zjncs opened a new pull request, #11133:
URL: https://github.com/apache/rocketmq/pull/11133

   ### Motivation
   
   `mqadmin rocksDBConfigToJson` with a bad `-t` value printed an "Invalid 
configType" message and returned `null` from `getConfigTypeList`, but execution 
then continued with the null list: local mode threw a raw 
`NullPointerException` from `Objects.requireNonNull`, and rpc mode carried the 
null list into the export request sent to brokers.
   
   ### Modifications
   
   Throw a `SubCommandException` carrying the same message so the command 
aborts cleanly on an invalid `-t` value instead of failing later with an 
unrelated error.
   
   ### Verification
   
   Fail-before (new test, run against the unpatched code):
   
   ```
   Tests run: 1, Failures: 1, Errors: 0 -- 
RocksDBConfigToJsonCommandTest#testInvalidConfigTypeFailsWithCleanError
   java.lang.AssertionError: invalid configType must not surface as a 
NullPointerException
   ```
   
   Pass-after:
   
   ```
   Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 -- 
RocksDBConfigToJsonCommandTest
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to