unbridled-41 commented on PR #4243: URL: https://github.com/apache/rocketmq-dashboard/pull/4243#issuecomment-5637960875
## Verification evidence **CI**: This PR's head SHA `2749169acae382a877d26d48e881ffc76bfd6511` has exactly one workflow run — "CI" (pull_request), run id 34625863869, conclusion `startup_failure`; check-runs API returns 0. The upstream workflow has been failing at startup for all PRs in this repository (including every recently merged one), so no CI signal is available; all verification below was run locally. **Red-light actual output** (before the fix): Service level (`mvn -o test -Dtest='AlertServiceTest#...'`): ``` ERROR Tests run: 1, Failures: 1 ... AlertServiceTest.acknowledgingReminderEventShouldAcknowledgeItsActiveRuleStateTest ``` (the `verify(alertStateRepository).acknowledge(...)` invocation never happened for the REMINDER event) Mapper level (`mvn -o test -Dtest='RmqAlertStateMapperIntegrationTest'`): ``` ERROR acknowledgeFiringShouldAcceptReminderTimesOfTheCurrentEpisodeTest -- expected: 1 but was: 0 Tests run: 2, Failures: 1, Errors: 0 ``` **Module tests** (after the fix): `mvn -o test -Dtest='org.apache.rocketmq.studio.ops.alert.*Test'` → all 33 alert-package test classes pass, notably `AlertServiceTest 77/77` (76 pre-existing incl. the unchanged FIRING and RESOLVED acknowledge tests + 1 new), `RmqAlertStateMapperIntegrationTest 2/2` (new), `MybatisPlusAlertStateRepositoryTest 5/5`, `AlertStateMachineTest 7/7`, `NotificationOutboxMapperIntegrationTest 2/2`. **Full suite + baseline**: `mvn -o test` on this branch → `Tests run: 2154, Failures: 2, Errors: 0`. Both failures are the documented pre-existing baseline failures (`AuthCorsIntegrationTest.shouldStillRejectAnonymousProtectedRequests`, `AuthCorsIntegrationTest.shouldRejectNonAdminMutationBeforeControllerExecution` — this class is recorded as failing ×2 in the repository baseline from previous rounds; the Aliyun baseline failure did not occur in this run). Zero new failures. **Build**: `mvn -o test` compiles all main and test sources before running (BUILD FAILURE only at the test-failure gate of the two baseline classes); the three changed/added files compile with no warnings introduced. **Diff self-check**: `git show --numstat HEAD` → `6 2 AlertService.java`, `1 1 RmqAlertStateMapper.java`, `14 0 AlertServiceTest.java`, `93 0 RmqAlertStateMapperIntegrationTest.java` (new); 4 files, +114/−3, no unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
